Merged
Conversation
This patch adds a link to the MWU warning banner to make it easier for developers to file issues or suggestions for improvements.
`setSearchParams` was overwriting the changes from `rawSearchParams.set`
…nge (#983) This PR is a fix for [Bug 1999795](https://bugzilla.mozilla.org/show_bug.cgi?id=1999795). The reporter noticed that after clearing a search term, changing the framework creates an url with the old search term intact. This is not the expected behavior. This PR replaces `setSearchParams` with `updateRawSearchParams` for onFrameworkChange and onTestVersionChange, using the custom hook for updating the search params. To test with production version bug: [Production Link](https://perf.compare/compare-results?baseRev=e5e0964a228d62e9f77b29e93e8b0d8e6ef15a5a&baseRepo=try&newRev=89ebb0972d42440367c8420ed0fbd10721177c2b&newRepo=try&framework=13&search=speedo) 1. Clear the search term speedo 2. It should be clear in the url. 3. Change the framework from browsertime to talos 4. The url still has the search=speedo ### To test with deployed version: [DeployLink](https://deploy-preview-983--mozilla-perfcompare.netlify.app/compare-results?baseRev=e5e0964a228d62e9f77b29e93e8b0d8e6ef15a5a&baseRepo=try&newRev=89ebb0972d42440367c8420ed0fbd10721177c2b&newRepo=try&framework=13&test_version=mann-whitney-u&search=speedo) 1. Clear the search term speedo 2. It should be clear in the url. 3. Change the framework from browsertime to talos 4. The url should not have the search term speedo
⬆️ Update all npm dependencies (2025-12-12) Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
⬆️ Update all npm dependencies (2025-12-16) Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
) This PR adds the missing framework 18, mozharness. It was missing according to [Bug 20004156](https://bugzilla.mozilla.org/show_bug.cgi?id=2004156).
⬆️ Update all npm dependencies (2026-01-09) Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
…d framework in url (#988) * needed to trigger loader to rerun for results table in test version switch * removed updateRawSearchParams and updated tests * revert to using react router's setSearchParams to trigger reload of loader for results table * alternative fix for bug 1999795 * Update ResultsTable.tsx
⬆️ Update react-router to version 7.12.0 Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
update codeowners
⬆️ Update all npm dependencies (2026-01-14) Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
* ⬆️ Update all npm dependencies (2026-01-20) * Add postinstall script to run fix-all command * Fix formatting in package.json * Change postinstall script to run test:update * removed postinstall cmd * update snapshots --------- Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com> Co-authored-by: Kala Severe <csevere@mozilla.com>
⬆️ Update all npm dependencies (2026-01-28) Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
* Bug 1919317: Fix the tooltip for Total Runs column This change wraps the Base runs and New Runs in a single combined Tooltip mui element. This provides a combined tooltip rather than having to use the title provided by the individual span elements. This update has been applied to the RevisionRow and SubtestsRevisionRow components. * Bug-1919317: Running npm run fix-all Adding updates after running `npm run fix-all`. * Bug-1919317: Use title in parent div This change combines the tooltip by: * Removing individual attributes from the individual spans * Adding title attribute to the parent div * Bug-1919317: Implement Review comments This commit implements review comments by: * Settings the `cursor` attribute to `pointer` for the `total-runs` class in both `RevisionRow.tsx` and `SubtestsRevisionRow.tsx`
⬆️ Update all npm dependencies (2026-02-04) Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
* Bug-2003016: Constrain the clickable area of the Home button Add the `display: inline-flex` property to the `Link` element used for the `Home` button. This will constrain the clickable area to only the wrapped elements and not extend it to the entire row. It was earlier extending to entire row as the wrapped elements are block elements. Fixes [Bug-2003016](https://bugzilla.mozilla.org/show_bug.cgi?id=2003016) * Bug-2003016: Added inline elements and replaced screenshots Made the below updates: * Replaced <p> with <Box> and made the <Stack> inline * Updated screenshots * Bug-2003016: Use MUI spacing on Box element Implemented the review comments by: * Using MUI space of `mb: 3` instead of the `styles`. This will have the styles match the original. I have also regenerated the screenshots by running `npm run fix-all`.
⬆️ Update all npm dependencies (2026-02-10) Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
…d by default (#999) * make mann-whitney-u the default test version with replicates enabled by default Replicates stay disabled by default for student-t Updates tests * update snapshots * update snapshots again * add test coverage * added test warning for studentT
✅ Deploy Preview for mozilla-perfcompare ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[gmierz]
[kala-moz]
Our new contributor [moijes12]